Postgres Pro
Downloads
Home   >   mailing lists

Re: Pluggable toaster - Mailing list pgsql-hackers

From Nikita Malakhov
Subject Re: Pluggable toaster
Date
Msg-id CAN-LCVOA9y8enbxfci9O28TeETARBrrnuu0aBowS=MSBMJnWaA@mail.gmail.com
Whole thread Raw
In response to Re: Pluggable toaster  (Greg Stark <stark@mit.edu>)
Responses Re: Pluggable toaster  (Greg Stark <stark@mit.edu>)
List pgsql-hackers
Tree view
Hi,
Have found code corrupted by merge went unnoticed in dummy_toaster.c.
Please look at the attached patches. They must be applied sequentially, one after another, 
from the 1st one. I haven't seed any warnings during compilation (with gcc on Ubuntu 20), 
and check-world goes with no errors.

On Thu, Mar 31, 2022 at 11:15 PM Greg Stark <stark@mit.edu> wrote:
It looks like it's still not actually building on some compilers. I
see a bunch of warnings as well as an error:

[03:53:24.660] dummy_toaster.c:97:2: error: void function
'dummyDelete' should not return a value [-Wreturn-type]

Also the "publication" regression test needs to be adjusted as it
includes \d+ output which has changed to include the toaster.


--
Regards,
Nikita Malakhov
Postgres Professional 
Attachment

pgsql-hackers by date:

Previous
From: James Coleman
Date:
Subject: Re: Restructure ALTER TABLE notes to clarify table rewrites and verification scans
Next
From: Nathan Bossart
Date:
Subject: Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages