Re: [HACKERS] Logical decoding on standby - Mailing list pgsql-hackers

On 20 March 2017 at 17:03, Craig Ringer <craig@2ndquadrant.com> wrote:
> On 20 March 2017 at 14:57, Simon Riggs <simon.riggs@2ndquadrant.com> wrote:
>
>> 2.1 Why does call to ReplicationSlotAcquire() move earlier in
>> pg_logical_slot_get_changes_guts()?
>
> That appears to be an oversight from an earlier version where it
> looped over timelines in pg_logical_slot_get_changes_guts . Reverted.
>
>> 2.2 sendTimeLineIsHistoric looks incorrect, and at least isn't really
>> documented well.
>> The setting
>>   sendTimeLineIsHistoric = state->currTLI == ThisTimeLineID;
>> should be
>>   sendTimeLineIsHistoric = (state->currTLI != ThisTimeLineID);
>
> Definitely wrong. Fixed.

Attached.

-- 
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers