Re: PostgreSQL Version 10, missing minor version - Mailing list pgsql-hackers

From Craig Ringer
Subject Re: PostgreSQL Version 10, missing minor version
Date
Msg-id CAMsr+YHPGq0HjqZ47ynSxO0LSPmmRgtSwCH8qVKAWbpogfgvYQ@mail.gmail.com
Whole thread Raw
In response to Re: PostgreSQL Version 10, missing minor version  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: PostgreSQL Version 10, missing minor version  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On 29 August 2016 at 02:52, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> "Regina Obe" <lr@pcorp.us> writes:
>> The routine in PostGIS to parse out the version number from pg_config is
>> breaking in the 10 cycle
>
> TBH, I wonder why you are doing that in the first place; it does not
> seem like the most reliable source of version information.  If you
> need to do compile-time tests, PG_CATALOG_VERSION is considered the
> best thing to look at, or VERSION_NUM in Makefiles.

This is my cue to pop up and say that if you're looking at the startup
message you have to use the version string, despite it not being the
most reliable source of information, because we don't send
server_version_num  ;)

Patch attached. Yes, I know PostGIS doesn't use it, but it makes no
sense to tell people not to parse the server version out in some
situations then force them to in others.

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: [PATCH] Transaction traceability - txid_status(bigint)
Next
From: Andres Freund
Date:
Subject: Re: [PATCH] Transaction traceability - txid_status(bigint)