On 05/12/17 21:07, Robert Haas wrote: > > Generally we write if (a && b) { ... } not if (a) { if (b) .. } >
It's rather ugly with && because one of the conditions is two line, but okay here you go. I am keeping the brackets even if normally don't for one-liners because it's completely unreadable without them IMHO.
Yeah, that's why I passed on that FWIW. Sometimes breaking up a condition is nice. Personally I intensely dislike the convention of
if (big_condition && big_condition)
one_linerdo_something;
as awfully unreadable, but I guess code convention means you live with things you don't like.
Anyway, I've just hit this bug in the wild for the umpteenth time this year, and I'd like to know what I can do to help progress it to commit+backport.
