Re: Re: [COMMITTERS] pgsql: Enable logical slots to follow timeline switches - Mailing list pgsql-hackers

From Craig Ringer
Subject Re: Re: [COMMITTERS] pgsql: Enable logical slots to follow timeline switches
Date
Msg-id CAMsr+YHMamHM7MUZOPpJOa7e3Z+d8E+-W+xH984J3EfOrLfUQw@mail.gmail.com
Whole thread Raw
In response to Re: Re: [COMMITTERS] pgsql: Enable logical slots to follow timeline switches  (Craig Ringer <craig@2ndquadrant.com>)
Responses Re: Re: [COMMITTERS] pgsql: Enable logical slots to follow timeline switches  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On 1 April 2016 at 12:47, Craig Ringer <craig@2ndquadrant.com> wrote:
 
I'll prep a follow-up patch. 


Done and attached.

Note that I can't use PG_GETARG_TRANSACTIONID directly since it's a macro defined only in xid.c . It didn't seem worth extracting it and moving it to postgres.h (where the other non-ADT-specific PG_GETARG_ macros are) or its own new header just for this, so I've spelled it out each time.

I now remember that that's part of why I used bigint as an argument type. The other part is that txid_current() returns bigint and there's no cast from bigint to xid. So the tests would have to CREATE CAST or cast via 'text'. They now do the latter.

We should probably have a cast from bigint to/from xid, but the type is so little-used that it's not much fuss.

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH v10] GSSAPI encryption support
Next
From: Kouhei Kaigai
Date:
Subject: EPQ recheck across HashJoin, what does it actuall check?