Postgres Pro
Downloads
Home   >   mailing lists

9.4.19 devel packages pg_config.h broken - Mailing list pgsql-pkg-yum

From Craig Ringer
Subject 9.4.19 devel packages pg_config.h broken
Date
Msg-id CAMsr+YGkkbB2VQsw4-kE36SO9hsgywCSCdb6Z0GafSjY5dDR+g@mail.gmail.com
Whole thread Raw
Responses Re: 9.4.19 devel packages pg_config.h broken  (Craig Ringer <craig@2ndquadrant.com>)
Re: 9.4.19 devel packages pg_config.h broken  (Devrim Gündüz <devrim@gunduz.org>)
List pgsql-pkg-yum
Tree view
Hi folks

The 9.4.19 devel package appears to have a misplaced pg_config.h. Compare:

$ rpm -qlp ~/Downloads/postgresql94-devel-9.4.19-1PGDG.f27.x86_64.rpm |grep 'pg_config.h'
/usr/pgsql-9.4/include/postgresql-94-ecpg_config.h
/usr/pgsql-9.4/include/postgresql-94-pg_config.h
/usr/pgsql-9.4/include/server/postgresql-94-pg_config.h

with

$ rpm -qlp ~/Downloads/postgresql96-devel-9.6.10-1PGDG.f27.x86_64.rpm |grep 'pg_config.h'
/usr/pgsql-9.6/include/ecpg_config.h
/usr/pgsql-9.6/include/pg_config.h
/usr/pgsql-9.6/include/server/pg_config.h

Note we have postgresql-94-pg_config.h in 9.4, and pg_config.h in 9.6.

I suspect this was an unintended change. I can't see where it came from in any recent commits, which is a bit surprising.

There's

Source5:    %{sname}-%{pgmajorversion}-pg_config.h

in the redhat master packages for postgresql, but that's fine/normal. Changes in 3a4b12670 on May 10 added unified Makefile for PostgreSQL 9.4, which seems to have changed

Source5:    pg_config.h
to
Source5:    %{sname}-%{pgmajorversion}-pg_config.h

and I'm guessing the problem got introduced there somehow.

I suspect the issue is that the 9.4 spec rpm/redhat/9.4/postgresql/master/postgresql-9.4.spec has

                %{__install} -m 644 %{SOURCE5} %{buildroot}%{pgbaseinstdir}/include/

(line 715)

wheras the pg10 spec rpm/redhat/10/postgresql/master/postgresql-10.spec has

                %{__install} -m 644 %{SOURCE5} %{buildroot}%{pgbaseinstdir}/include/pg_config.h

Note the destination file name specified for pg10 but not 9.4.




--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgsql-pkg-yum by date:

Previous
From: Justin Pryzby
Date:
Subject: PG11 beta3 packages and RH6 schedule
Next
From: Craig Ringer
Date:
Subject: Re: 9.4.19 devel packages pg_config.h broken