Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Transaction traceability - txid_status(bigint) - Mailing list pgsql-hackers

From Craig Ringer
Subject Re: [PATCH] Transaction traceability - txid_status(bigint)
Date
Msg-id CAMsr+YGAE3zRrA1RNcLxj30zK=F+jGeecJXXX93Bqh_PdaEgtw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Transaction traceability - txid_status(bigint)  (David Steele <david@pgmasters.net>)
List pgsql-hackers
Tree view


On 31 Mar. 2017 22:31, "David Steele" <david@pgmasters.net> wrote:
On 3/25/17 12:12 AM, Peter Eisentraut wrote:
I'm wondering if this is a perl version/platform issue around

    $tx->pump until $stdout =~ /[[:digit:]]+[\r\n]$/;

where we're not recognising the required output from psql when we get it.

What's in src/test/recovery/tmp_check/log/regress_log_011* ?

I couldn't use PostgresNode::psql or PostgresNode::safe_psql here
because the session must stay open.

The problem was that psql needs to be called with -X.  Fix committed.

It's not clear to me what remains to be done on this patch.  I feel, at the least, that patches 3 and 4 need to be rebased and the status set back to "Needs Review".

This thread has been idle for six days.  Please respond with a new patch by 2017-04-04 00:00 AoE (UTC-12) or this submission will be marked "Returned with Feedback".

I consider the feature complete and committed.

Patch 3 is optional and per discussion buried upthread we generally agreed that it'd be better to replace most user visible uses of the 'xid' data type with a new epoch extended 'xid64' or similar.

Patch 4, txid_incinerate, has never been intended for commit. It's a testing tool.

Patches 1 and 2 were the key parts and thanks to Robert's helpful review, advice and edits they're committed now.

Committed, done. Yay.

pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: Adding support for Default partition in partitioning
Next
From: David Steele
Date:
Subject: Re: PATCH: pageinspect / add page_checksum andbt_page_items(bytea)