Re: Remove Windows crash dump support? - Mailing list pgsql-hackers

From Craig Ringer
Subject Re: Remove Windows crash dump support?
Date
Msg-id CAMsr+YG=UOZeiA1Z=U3VE-A6F_QdOtNKwkXF=MirmD3BSTBc6A@mail.gmail.com
Whole thread Raw
In response to Re: Remove Windows crash dump support?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Remove Windows crash dump support?  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On 22 December 2015 at 23:46, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> In which version(s) of Windows was this improvement added?

Vista and Server 2008 (original, not R2).


Win7 and Server 2003 are already irrelevant now, and will be absurdly so by the time Pg 9.6 comes out.

The windows feature works better than the in-application crash dump. It can limit the number of dumps, for one thing, and it doesn't require a sane and intact stack to work.
 
Even if it's all good in recent Windows, the impression I have is that an
awful lot of people are still running older versions, so I'd be pretty
hesitant to just drop the code.

Yeah, if it was new in Win2012 I'd agree, but it's been around since 2008.
 
Also, AFAICS it's pretty self-contained
and hence not much of a drag on development.  Is there any positive reason
to remove it?

Not really. It also does nothing by default, so it's pretty harmless and mostly dead code.

I just thought it was worth bringing up that there's a better way to do it now and nobody seems to use it anyway.

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgsql-hackers by date:

Previous
From: "Joshua D. Drake"
Date:
Subject: Re: Remove Windows crash dump support?
Next
From: Michael Paquier
Date:
Subject: Re: WIP: Fix parallel workers connection bug in pg_dump (Bug #13727)