Re: Failed to delete old ReorderBuffer spilled files - Mailing list pgsql-hackers

From Craig Ringer
Subject Re: Failed to delete old ReorderBuffer spilled files
Date
Msg-id CAMsr+YG31Je0e3BhiG2eQmWBPPbgG2zbH3o4r-psykOCNNu3ZQ@mail.gmail.com
Whole thread Raw
In response to Failed to delete old ReorderBuffer spilled files  (atorikoshi <torikoshi_atsushi_z2@lab.ntt.co.jp>)
Responses Re: Failed to delete old ReorderBuffer spilled files  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On 20 November 2017 at 18:35, atorikoshi <torikoshi_atsushi_z2@lab.ntt.co.jp> wrote:
Hi,

I put many queries into one transaction and made ReorderBuffer spill
data to disk, and sent SIGKILL to postgres before the end of the
transaction.

After starting up postgres again, I observed the files spilled to
data wasn't deleted.

Since this can only happen  on crash exits, and the reorderbuffer data is useless after a decoding backend exits, why don't we just recursively delete the tree contents on Pg startup?

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Failed to delete old ReorderBuffer spilled files
Next
From: Craig Ringer
Date:
Subject: Re: Logical Replication and triggers