Re: Proposal:Use PGDLLEXPORT for libpq - Mailing list pgsql-hackers

From Craig Ringer
Subject Re: Proposal:Use PGDLLEXPORT for libpq
Date
Msg-id CAMsr+YFp63SYo2VinHuwMeLGjNc60fr1deTxmJT=tgrX3kHFBg@mail.gmail.com
Whole thread Raw
In response to Proposal:Use PGDLLEXPORT for libpq  (Yury Zhuravlev <u.zhuravlev@postgrespro.ru>)
Responses Re: Proposal:Use PGDLLEXPORT for libpq  (Yury Zhuravlev <u.zhuravlev@postgrespro.ru>)
List pgsql-hackers

On 26 January 2016 at 23:04, Yury Zhuravlev <u.zhuravlev@postgrespro.ru> wrote:
Hello hackers.
Why we do not use PGDLLEXPORT (__declspec (dllexport)) for the libpq (and other dlls)?
Now we are using black magic with gendef.pl for get def (aka export.txt) from .obj files.
I have set for some functions and it works.
Perhaps there is a circumstance that I do not know but my version seems to me simplify build under Windows.

See


and 


(sorry for HTML horror)

for history.

TL;DR:  PGDLLEXPORT is considered ugly Windows-droppings in the code and so a less visible, albeit more convoluted, solution is used.


--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: pglogical - logical replication contrib module
Next
From: Simon Riggs
Date:
Subject: Re: remove wal_level archive