Re: [HACKERS] [PATCH] Off-by-one error in logical slot resource retention - Mailing list pgsql-hackers

From Craig Ringer
Subject Re: [HACKERS] [PATCH] Off-by-one error in logical slot resource retention
Date
Msg-id CAMsr+YE5D=_cD3TJmYipzB9-mXCE8b9uO6fcr9HbN__H1hh2jQ@mail.gmail.com
Whole thread Raw
In response to [HACKERS] [PATCH] Off-by-one error in logical slot resource retention  (Craig Ringer <craig@2ndquadrant.com>)
Responses Re: [HACKERS] [PATCH] Off-by-one error in logical slot resource retention  (Aleksander Alekseev <a.alekseev@postgrespro.ru>)
List pgsql-hackers
On 9 March 2017 at 11:17, Craig Ringer <craig@2ndquadrant.com> wrote:
> Hi all
>
> I've found a minor off-by-one error in the resource retention logic
> for logical slots, where we treat confirmed_flush as meaning "flushed
> up to and including this LSN". Seems reasonable, but the rest of the
> code treats it as "flushed up to but excluding this LSN". In
> particular, we treat confirmed_flush as the inclusive startpoint for a
> new logical decoding session if no startpoint is provided by the
> client and will replay a change whose commit record begins at exactly
> confirmed_flush to the client.

This should be backpatched to 9.4.

The others do not need backpatching.

-- Craig Ringer                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Roman Shaposhnik
Date:
Subject: [HACKERS] [PATCH] Enabling atomics on ARM64
Next
From: "Okano, Naoki"
Date:
Subject: Re: [HACKERS] Adding the optional clause 'AS' in CREATE TRIGGER