Re: Proposal: Generic WAL logical messages - Mailing list pgsql-hackers

From Craig Ringer
Subject Re: Proposal: Generic WAL logical messages
Date
Msg-id CAMsr+YE0=Ma-MUm67-Vg6ku4zSvRvXtB+uk0UiXk3QObrZkdWg@mail.gmail.com
Whole thread Raw
In response to Re: Proposal: Generic WAL logical messages  (Artur Zakirov <a.zakirov@postgrespro.ru>)
Responses Re: Proposal: Generic WAL logical messages
List pgsql-hackers
On 17 March 2016 at 19:08, Artur Zakirov <a.zakirov@postgrespro.ru> wrote:
On 16.03.2016 18:56, David Steele wrote:

This patch applies cleanly and is ready for review with no outstanding
issues that I can see.  Simon and Artur, you are both signed up as
reviewers.  Care to take a crack at it?

Thanks,


I have tested the patch once again and have looked the code. It looks good for me. I haven't any observation.

The patch does its function correctly. I have tested it with a plugin, which writes DDL queries to the WAL using a hook and replicates this queries at subscribers.

Would you mind sharing the plugin here? I could add it to src/test/modules and add some t/ tests so it runs under the TAP test framework.


--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Proposal: Generic WAL logical messages
Next
From: Amit Kapila
Date:
Subject: Re: Performance degradation in commit ac1d794