Re: Getting rid of aggregate_dummy() - Mailing list pgsql-hackers

From Isaac Morland
Subject Re: Getting rid of aggregate_dummy()
Date
Msg-id CAMsGm5dOMcipAwJS3rd+_TNRQtZzZ_WCziVdPreXXoAU+v63yw@mail.gmail.com
Whole thread Raw
In response to Getting rid of aggregate_dummy()  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Getting rid of aggregate_dummy()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sun, 1 Nov 2020 at 15:47, Tom Lane <tgl@sss.pgh.pa.us> wrote:
 
Anyway, this saves about 3KB in fmgrtab.o, without any downside
that I can see.  If someone accidentally called an aggregate as
a normal function, they'd now get a different error message,
namely "internal function "aggregate_dummy" is not in internal lookup
table" instead of "aggregate function NNN called as normal function".
That doesn't really seem like a problem.
 
Speaking as somebody who sometimes does really dumb things, I don’t like this change in error message. The current message clearly identifies the problem; the new message makes it look like there is a bug in Postgres.

pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: Prevent printing "next step instructions" in initdb and pg_upgrade
Next
From: Thomas Munro
Date:
Subject: Re: Collation versioning