Postgres Pro
Downloads
Home   >   mailing lists

patch: change magic constants to DEFINE value for readability. - Mailing list pgsql-hackers

From CharSyam
Subject patch: change magic constants to DEFINE value for readability.
Date
Msg-id CAMrLSE5j_aWfoBDMrSvk14oBKSy+-2cjzNNH_FciirA7Kwo9TA@mail.gmail.com
Whole thread Raw
Responses Re: [HACKERS] patch: change magic constants to DEFINE value for readability.  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Tree view
in src/backend/utils/misc/tzparser.c

It uses 60 * 60 to represent SECS_PER_HOUR.

and It is already define in other files.

so I think using SECS_PER_HOUR is more clear for readability.

and I attached patch.(it just change 60 * 60 to SECS_PER_HOUR)

What do you think?
Attachment

pgsql-hackers by date:

Previous
From: Eric Ridge
Date:
Subject: Re: Change pg_cancel_*() to ignore current backend
Next
From: Amit Kapila
Date:
Subject: Re: Issues in Replication Progress Tracking