On Sun, Oct 14, 2012 at 8:53 PM, Josh Kupershmidt <<a href="javascript:;">schmiddy@gmail.com</a>> wrote:<br />
>Hi all,<br /> > It seems the queries in ./src/tutorial/syscat.source use string<br /> > escaping with the
assumptionthat standard_conforming_strings is off,<br /> > and thus give wrong results with modern versions. A
simplefix is<br /> > attached.<br /><br /> Hi Josh,<br /><br /> Do you propose back-patching this? You could argue
thatthis is a bug in 9.1 and 9.2. Before that, they generate deprecation warnings, but do not give the wrong
answer.<br/><br /> If it is only to be applied to HEAD, or only to 9.1, 9.2, and HEAD, then this part seems to be
unnecessaryand I think should be removed (setting a value to its default is more likely to cause confusion than remove
confusion):<br/><br /> SET standard_conforming_strings TO on;<br /><br /> and the corresponding reset as well.<br /><br
/>Other than that, it does what it says (fix a broken example), does it cleanly, we want this, and I have no other
concerns.<br/><br /> I guess the src/tutorial directory could participate in regression tests, in which case this
problemwould have been detected when introduced, but I don't think I can demand that you invent regression tests for a
featureyou are just fixing rather than creating.<br /><br /> Thanks for the patch,<br /><br /> Jeff<br />
