Postgres Pro
Downloads
Home   >   mailing lists

Re: vac truncation scan problems - Mailing list pgsql-hackers

From Jeff Janes
Subject Re: vac truncation scan problems
Date
Msg-id CAMkU=1zss-1_pbcUZ1oMgTkF_rsi1t4Z+nYKf3CCHStzfvyvEg@mail.gmail.com
Whole thread Raw
In response to Re: vac truncation scan problems  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Responses Re: vac truncation scan problems
List pgsql-hackers
Tree view
On Tue, Mar 31, 2015 at 1:28 AM, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> wrote:
Hi, this is a bug in the commit 0d831389749a3baaced7b984205b9894a82444b9 .

It allows vucuum freeze to be skipped and inversely lets regular
vacuum wait for lock. The attched patch fixes it.


In table_recheck_autovac, vacuum options are determined as following,

 >      tab->at_vacoptions = VACOPT_SKIPTOAST |
 >              (dovacuum ? VACOPT_VACUUM : 0) |
 >              (doanalyze ? VACOPT_ANALYZE : 0) |
!>              (wraparound ? VACOPT_NOWAIT : 0);

The line prefixed by '!' looks inverted.

Thanks, it is obvious once you see it!

Your patch solved the problem for me.

Cheers,

Jeff

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );
Next
From: Jeff Janes
Date:
Subject: Re: vac truncation scan problems