Re: patch: avoid heavyweight locking on hash metapage - Mailing list pgsql-hackers

From Jeff Janes
Subject Re: patch: avoid heavyweight locking on hash metapage
Date
Msg-id CAMkU=1yU51ehsEDAQcUki4rHiY_0apzW3S+ej5W1MQBBnD7HyQ@mail.gmail.com
Whole thread Raw
In response to Re: patch: avoid heavyweight locking on hash metapage  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: patch: avoid heavyweight locking on hash metapage
List pgsql-hackers
On Mon, Jun 18, 2012 at 5:42 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>
> Hmm.  That was actually a gloss I added on existing code to try to
> convince myself that it was safe; I don't think that the changes I
> made make that any more or less safe than it was before.

Right, sorry.  I thought there was some strength reduction going on
there as well.

Thanks for the various explanations, they address my concerns.  I see
that v2 applies over v1.

I've verified performance improvements using 8 cores with my proposed
pgbench -P benchmark, with a scale that fits in shared_buffers.
It brings it most of the way, but not quite, up to the btree performance.


I've marked this as ready for committer.

Cheers,

Jeff


pgsql-hackers by date:

Previous
From: Satoshi Nagayasu
Date:
Subject: Re: pg_stat_lwlocks view - lwlocks statistics
Next
From: Satoshi Nagayasu
Date:
Subject: Re: pg_stat_lwlocks view - lwlocks statistics