Re: Setting visibility map in VACUUM's second phase - Mailing list pgsql-hackers

From Jeff Janes
Subject Re: Setting visibility map in VACUUM's second phase
Date
Msg-id CAMkU=1y4joaSQAtJC_ekFa5VzBq7bYxGcYDEAxLRLu+BroYwnQ@mail.gmail.com
Whole thread Raw
In response to Re: Setting visibility map in VACUUM's second phase  (Pavan Deolasee <pavan.deolasee@gmail.com>)
Responses Re: Setting visibility map in VACUUM's second phase
List pgsql-hackers
On Friday, December 7, 2012, Pavan Deolasee wrote:
 
Revised patch attached. This time much less invasive. I added a new
function heap_page_is_all_visible() to check if the given page is
all-visible and also return the visibility cutoff xid.

Hi Pavan,

lazy_vacuum_page now pins and unpins the vmbuffer for each page it marks all-visible, which seems like a lot of needless traffic since the next vmbuffer is likely to be the same as the previous one.

Could it instead get vmbuffer passed down to it from the two calling sites?   (One call site would have to have it introduced, just for this purpose, the other should be able to use its existing one.)

Cheers,

Jeff

pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: logical changeset generation v4 - Heikki's thoughts about the patch state
Next
From: Kohei KaiGai
Date:
Subject: Re: [sepgsql 1/3] add name qualified creation label