Re: Regarding storenode in Slony - Mailing list pgadmin-hackers

From Neel Patel
Subject Re: Regarding storenode in Slony
Date
Msg-id CAMcbDBFc=-siXUoNyxc0zY86diTxWhHkmv4GF8SRFk7zz9iRDQ@mail.gmail.com
Whole thread Raw
In response to Re: Regarding storenode in Slony  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
List pgadmin-hackers
Hi Ashesh,


On Mon, Oct 14, 2013 at 6:28 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:


On 14 Oct 2013 18:21, "Neel Patel" <neel.patel@enterprisedb.com> wrote:
>
> Hi,
>
> As per the slony documentation and code "storenode" API requires below two arguments.
>
> storenode(p_no_comment integer, p_no_id text)
Have you cross checked with older version of Slony1?

Yes Ashesh you are right. I have checked till slony version 2.0 but now I have checked older version also 1.1 & 1.2, in that "storenode" requires three arguments.

So I will fix this along with slony 2.2.0 support issue that i am currently working on and send the updated patch.

 

>
>
> As per the pgAdmin code we are executing below SQL which is wrong.
>
> SELECT "_<cluster_name>".storeNode(99, 'AdminNode', false);
>
>
> Following are the steps ( PostgreSQL 9.2 ):
>
> 1. Go to any database and right click "New Slony I cluster ..."
>
> 2.  In the dialog give following inputs.
>
>      Join existing cluster --- Uncheck
>      Cluster name ---- MyCluster
>       Local node ---- 1 , MasterNode
>       Admin node --- 99, AdminNode
>       Comment ---- TestComment
>
> 3. Click "OK" button.
>
> 4. Error will come saying  "function _MyCluster.storenode(integer, unknown, boolean) does not exists".
>
> We need only two arguments to "storenode()" function.
>
> Why we are passing three arguments to the storeNode() API ? Any Specific reason ?
>
> Thanks,
> Neel Patel
>
>
>
>
>
>
>
>
> Is there any specific reason to


pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: Re: Regarding storenode in Slony
Next
From: Dave Page
Date:
Subject: Re: pgAgent: C++ Port - Patch Review