Re: Some dead code in get_param_path_clause_serials() - Mailing list pgsql-hackers

From Richard Guo
Subject Re: Some dead code in get_param_path_clause_serials()
Date
Msg-id CAMbWs4_tC4teQuqPjbhtwTM930djDjUfjBUPoYgMiBWWdhzngQ@mail.gmail.com
Whole thread Raw
In response to Re: Some dead code in get_param_path_clause_serials()  (Andrei Lepikhov <lepihov@gmail.com>)
List pgsql-hackers
On Wed, Nov 13, 2024 at 9:59 PM Andrei Lepikhov <lepihov@gmail.com> wrote:
> On 11/13/24 16:34, Richard Guo wrote:
> > The function get_param_path_clause_serials() is used to get the set of
> > pushed-down clauses enforced within a parameterized Path.  Since we
> > don't currently support parameterized MergeAppend paths, and it
> > doesn't look like that is going to change anytime soon (as explained
> > in the comments for generate_orderedappend_paths), we don't need to
> > consider MergeAppendPath in this function.  Is it worth removing the
> > related code, as attached?

> I've passed through the logic of
> get_param_path_clause_serials/reparameterize_path_by_child/reparameterize_path.
> Agree, it seems not useful to parameterise ordered appends in the near
> future.

Pushed.  Thank you for review.

Thanks
Richard



pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Reordering DISTINCT keys to match input path's pathkeys
Next
From: John Naylor
Date:
Subject: Re: branch-free tuplesort partitioning