Postgres Pro
Downloads
Home   >   mailing lists

Re: Crash after a call to pg_backup_start() - Mailing list pgsql-hackers

From Richard Guo
Subject Re: Crash after a call to pg_backup_start()
Date
Msg-id CAMbWs4_ZhZm0iWcj0-fhUAMLGccyRoXG5aTnAhVNwDkaYgnMXg@mail.gmail.com
Whole thread Raw
In response to Crash after a call to pg_backup_start()  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: Crash after a call to pg_backup_start()
List pgsql-hackers
Tree view

On Fri, Oct 21, 2022 at 3:10 PM Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:
It seems to me that the comment is true and the condition is a thinko.
 
Yeah, the two conditions could be both false. How about we update the
comment a bit to emphasize this? Such as

    /* At most one of these conditions can be true */
or
    /* These conditions can not be both true */
 
Please find the attached fix.
 
+1

Thanks
Richard

pgsql-hackers by date:

Previous
From: Ants Aasma
Date:
Subject: Re: Standby recovers records from wrong timeline
Next
From: Japin Li
Date:
Subject: Re: parse partition strategy string in gram.y