Is this an oversight in reparameterizing Memoize path? - Mailing list pgsql-hackers

From Richard Guo
Subject Is this an oversight in reparameterizing Memoize path?
Date
Msg-id CAMbWs4_R=ORpz=Lkn2q3ebPC5EuWyfZF+tmfCPVLBVK5W39mHA@mail.gmail.com
Whole thread Raw
Responses Re: Is this an oversight in reparameterizing Memoize path?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
When reviewing other patch I noticed there might be an oversight for
MemoizePath in reparameterize_path.  In reparameterize_path we are
supposed to increase the path's parameterization to required_outer.
However, AFAICS for MemoizePath we just re-create the same path thus its
parameterization does not get increased.

I'm not sure if this has consequences in practice.  Just from reading
the codes, it seems this may cause assertion failure after the call of
reparameterize_path.

    Assert(bms_equal(PATH_REQ_OUTER(path), required_outer));

Thanks
Richard

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_dump: Remove "blob" terminology
Next
From: Andrew Dunstan
Date:
Subject: Re: Error-safe user functions