Re: Improve join_search_one_level readibilty (one line change) - Mailing list pgsql-hackers

From Richard Guo
Subject Re: Improve join_search_one_level readibilty (one line change)
Date
Msg-id CAMbWs4_QKD4tNn6mmY7-u-HrzHcN4PM8-ope8vYtmpDkOuGXGQ@mail.gmail.com
Whole thread Raw
In response to Re: Improve join_search_one_level readibilty (one line change)  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Improve join_search_one_level readibilty (one line change)
List pgsql-hackers

On Fri, Aug 4, 2023 at 10:36 AM David Rowley <dgrowleyml@gmail.com> wrote:
The whole lnext() stuff all feels a bit old now that Lists are arrays.
I think we'd be better adjusting the code to pass the List index where
we start from rather than the ListCell to start from.  That way we can
use for_each_from() to iterate rather than for_each_cell().  What's
there today feels a bit crufty and there's some element of danger that
the given ListCell does not even belong to the given List.

I think we can go even further to do the same for 'bushy plans' case,
like the attached.

Thanks
Richard
Attachment

pgsql-hackers by date:

Previous
From: Yugo NAGATA
Date:
Subject: pgbench: allow to exit immediately when any client is aborted
Next
From: Andy Fan
Date:
Subject: Re: Extract numeric filed in JSONB more effectively