Postgres Pro
Downloads
Home   >   mailing lists

Re: Fix a typo of func DecodeInsert() - Mailing list pgsql-hackers

From Richard Guo
Subject Re: Fix a typo of func DecodeInsert()
Date
Msg-id CAMbWs49TkAn4c8JJS=5E7q4y5WjShzu+ZzwztupTrx7v6-jHgQ@mail.gmail.com
Whole thread Raw
In response to Fix a typo of func DecodeInsert()  (Yongtao Huang <yongtaoh2022@gmail.com>)
Responses Re: Fix a typo of func DecodeInsert()
List pgsql-hackers
Tree view

On Wed, Jan 17, 2024 at 8:47 AM Yongtao Huang <yongtaoh2022@gmail.com> wrote:
Hi all,
I think the comment above the function DecodeInsert() in src/backend/replication/logical/decode.c should be
+ * Inserts can contain the new tuple.
, rather than
- * Deletes can contain the new tuple.

Nice catch.  +1.

I kind of wonder if it would be clearer to state that "XLOG_HEAP_INSERT
can contain the new tuple", in order to differentiate it from
XLOG_HEAP2_MULTI_INSERT.

Thanks
Richard

pgsql-hackers by date:

Previous
From: Yongtao Huang
Date:
Subject: Fix a typo of func DecodeInsert()
Next
From: Masahiko Sawada
Date:
Subject: Re: Synchronizing slots from primary to standby