On Fri, Nov 19, 2021 at 1:13 PM Richard Guo <guofenglinux@gmail.com> wrote: > > Happened to notice this when reading around the codes. The BrinMemTuple > would be initialized in brin_new_memtuple(), right after being created. > So we don't need to initialize it again outside. > > diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c > index ccc9fa0959..67a277e1f9 100644 > --- a/src/backend/access/brin/brin.c > +++ b/src/backend/access/brin/brin.c > @@ -1261,8 +1261,6 @@ initialize_brin_buildstate(Relation idxRel, BrinRevmap *revmap, > state->bs_bdesc = brin_build_desc(idxRel); > state->bs_dtuple = brin_new_memtuple(state->bs_bdesc); > > - brin_memtuple_initialize(state->bs_dtuple, state->bs_bdesc); > - > return state; > }
Good catch. +1 for the change. Please submit a patch.
