Re: duplicated comments on get_relation_constraints - Mailing list pgsql-hackers

From Richard Guo
Subject Re: duplicated comments on get_relation_constraints
Date
Msg-id CAMbWs49GzbzTa_Qon1XxcB9BaApXYX_bZf=D+bZ_GVY2K9aVmw@mail.gmail.com
Whole thread Raw
In response to Re: duplicated comments on get_relation_constraints  (Kirill Reshke <reshkekirill@gmail.com>)
Responses Re: duplicated comments on get_relation_constraints
List pgsql-hackers
On Sat, Mar 29, 2025 at 1:38 AM Kirill Reshke <reshkekirill@gmail.com> wrote:
> On Fri, 28 Mar 2025 at 15:19, Richard Guo <guofenglinux@gmail.com> wrote:
> > On Fri, Mar 28, 2025 at 4:53 PM Kirill Reshke <reshkekirill@gmail.com> wrote:
> > > On Fri, 28 Mar 2025 at 09:47, jian he <jian.universality@gmail.com> wrote:
> > > > The first "Also ignore if NO INHERIT and we weren't told that that's
> > > > safe." is duplicated,
> > > > also it's in the wrong place?
> > > > The second one is fine.

> > > Hi! Indeed. Looks like an oversight from ca87c41. I think we can
> > > safely remove one of those, presumably the first one.

> > +1.  Also there is an extra blank line after the NO INHERIT check.  I
> > think we can remove it while we're here.

> Sure. PFA attached, if needed

The change looks good to me.  I plan to push it soon, barring any
objections.

Thanks
Richard



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Statistics Import and Export
Next
From: Nathan Bossart
Date:
Subject: Re: Statistics Import and Export