Re: Unsafe access BufferDescriptors array in BufferGetLSNAtomic() - Mailing list pgsql-hackers

From Richard Guo
Subject Re: Unsafe access BufferDescriptors array in BufferGetLSNAtomic()
Date
Msg-id CAMbWs48Vg+GzV+_fc+gqcoWQuMye9rXyWp=7R=ywLGusHcG58w@mail.gmail.com
Whole thread Raw
In response to Re: Unsafe access BufferDescriptors array in BufferGetLSNAtomic()  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: Unsafe access BufferDescriptors array in BufferGetLSNAtomic()
List pgsql-hackers
On Wed, Feb 19, 2025 at 9:44 AM Michael Paquier <michael@paquier.xyz> wrote:
> On Wed, Feb 19, 2025 at 09:36:35AM +0900, Richard Guo wrote:
> > I plan to push this shortly.  This is arguably a bug, but it hasn't
> > caused any real issues, and nobody has complained about it until now,
> > so I don't think it needs to be back-patched.  Any thoughts?
>
> I can see a point in doing a backpatch to keep the code consistent
> across branches, and this avoids incorrect access patterns when
> copy-pasting this code.

Hmm, fair point.  I will backpatch-through 13.

Thanks
Richard



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Issues with 2PC at recovery: CLOG lookups and GlobalTransactionData
Next
From: wenhui qiu
Date:
Subject: Re: [Feature Request] INSERT FROZEN to Optimize Large Cold Data Imports and Migrations