Re: Remove some redundant set_cheapest() calls - Mailing list pgsql-hackers

From Richard Guo
Subject Re: Remove some redundant set_cheapest() calls
Date
Msg-id CAMbWs48=XRhJdOHsySbht6_d0UXfd=9qEjwt8KnJkq0DJ-i7sA@mail.gmail.com
Whole thread Raw
In response to Re: Remove some redundant set_cheapest() calls  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

On Wed, Mar 27, 2024 at 10:59 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Richard Guo <guofenglinux@gmail.com> writes:
> On Wed, Mar 27, 2024 at 4:06 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I'm less convinced about changing this.  I'd rather keep it consistent
>> with mark_dummy_rel.

> Hm, I wonder if we should revise the comment there that states "but not
> when called from elsewhere", as it does not seem to be true.

I'd be okay with wording like "This is redundant in current usage
because set_rel_pathlist will do it later, but it's cheap so we keep
it for consistency with mark_dummy_rel".  What do you think?

That works for me.  Thanks for the wording.

Thanks
Richard

pgsql-hackers by date:

Previous
From: "Euler Taveira"
Date:
Subject: Re: Fix some resources leaks (src/bin/pg_basebackup/pg_createsubscriber.c)
Next
From: Richard Guo
Date:
Subject: Re: Properly pathify the union planner