Re: [PATCH] Simple code cleanup in tuplesort.c. - Mailing list pgsql-hackers

From Richard Guo
Subject Re: [PATCH] Simple code cleanup in tuplesort.c.
Date
Msg-id CAMbWs4-Mn=jBwaiXCLi1WvPsw3Hc-5MDf-zBTwZVwfkwFNvQ+Q@mail.gmail.com
Whole thread Raw
In response to [PATCH] Simple code cleanup in tuplesort.c.  (Xing Guo <higuoxing@gmail.com>)
Responses Re: [PATCH] Simple code cleanup in tuplesort.c.
Re: [PATCH] Simple code cleanup in tuplesort.c.
List pgsql-hackers

On Wed, Jul 27, 2022 at 5:10 PM Xing Guo <higuoxing@gmail.com> wrote:
The bounded heap sorting status flag is set twice in sort_bounded_heap() and tuplesort_performsort(). This patch helps remove one of them.
 
Revisiting this patch I think maybe it's better to remove the setting of
Tuplesort status from tuplesort_performsort() for the TSS_BOUNDED case.
Thus we keep the heap manipulation routines, make_bounded_heap and
sort_bounded_heap, consistent in that they update their status
accordingly inside the function.

Also, would you please add it to the CF to not lose track of it?

Thanks
Richard

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Switching XLog source from archive to streaming when primary available
Next
From: Richard Guo
Date:
Subject: Re: Remove dead macro exec_subplan_get_plan