On Fri, Mar 9, 2018 at 12:34 AM, Michael Paquier <michael@paquier.xyz> wrote:
On Thu, Mar 08, 2018 at 11:04:20PM -0600, Jeremy Finzel wrote: > Since you mention, can anyone elaborate further on the memory leak danger > here? > > Line 193 in src/test/modules/worker_spi/worker_spi.c read: > # Note some memory might be leaked here. > > Is this any reason *not *to use this pattern in production?
quote_identifier may palloc the result, so the first pstrdup on the top to save "schema" and "table" refer to a pointer which may perhaps get lost. Those are just a couple of bytes, so the code complication is not worth the cleanup IMO. -- Michael
