Re: [PATCH] Add CHECK_FOR_INTERRUPTS in scram_SaltedPassword loop. - Mailing list pgsql-hackers

From Bowen Shi
Subject Re: [PATCH] Add CHECK_FOR_INTERRUPTS in scram_SaltedPassword loop.
Date
Msg-id CAM_vCufzLucPevjOC90cVD_AsPtpPHRLY2w+Zm985B-6JHxz1w@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add CHECK_FOR_INTERRUPTS in scram_SaltedPassword loop.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Add CHECK_FOR_INTERRUPTS in scram_SaltedPassword loop.
List pgsql-hackers
> I don't think it would be useful to limit this at an arbitrary point, iteration
> count can be set per password and if someone wants a specific password to be
> super-hard to brute force then why should we limit that?
I agree with that. Maybe some users do want a super-hard password.
RFC 7677 and RFC 5802 don't specify the maximum number of iterations.

> If we want to add CHECK_FOR_INTERRUPTS inside the loop I think a brief
> comment would be appropriate.

This has been completed in patch v2 and it's ready for review.

Regards
Bowen Shi
Attachment

pgsql-hackers by date:

Previous
From: Ray Eldath
Date:
Subject: Re: Adding a clang-format file
Next
From: Bharath Rupireddy
Date:
Subject: Re: Lockless exit path for ReplicationOriginExitCleanup