On Thu, Jul 2, 2020 at 11:11 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>
> On 2020-Mar-26, Mike Palmiotto wrote:
>
> Regarding 0001:
>
> > diff --git a/src/backend/postmaster/subprocess.c b/src/backend/postmaster/subprocess.c
> > new file mode 100644
> > index 0000000000..3e7a45bf10
> > --- /dev/null
> > +++ b/src/backend/postmaster/subprocess.c
> > @@ -0,0 +1,62 @@
> > +/*-------------------------------------------------------------------------
> > + *
> > + * subprocess.c
> > + *
> > + * Copyright (c) 2004-2020, PostgreSQL Global Development Group
> > + *
> > + *
> > + * IDENTIFICATION
> > + * src/backend/postmaster/syslogger.c
>
> Wrong file identification.
Thanks, I'll fix that.
<snip>
> > + WalReceiverType, /* end of Auxiliary Process Forks */
> > +
> > + NUMSUBPROCESSTYPES /* Must be last! */
> > +} SubprocessType;
>
> This sort of thing is messy and unfriendly to maintain. I suggest we
> use the same trick as in cmdtaglist.h and rmgrlist.h; see commits
> 2f9661311b83 and 5a1cd89f8f4a for examples.
Thanks for the reviews. I'm hoping to get to this next week (hopefully
sooner). It was on my TODO list to use this approach (from the last
round of reviews), so I'll make sure to do it first.
Other dangling items were the subprocess pids array and obviously the
rebase. I've got a decent AppVeyor/tap test workflow now, so it
should be a little less painful this time around.
Regards,
--
Mike Palmiotto
https://crunchydata.com
