Request a Demo
Home   >   mailing lists

Re: Proposal for better support of time-varying timezone abbreviations - Mailing list pgsql-hackers

From Chris Bandy
Subject Re: Proposal for better support of time-varying timezone abbreviations
Date
Msg-id CAMDg7Wwx-CjCj=XzkDhic+2O24-WNt2iv5fWdt=WusUfzHT+Sg@mail.gmail.com
Whole thread
In response to Re: Proposal for better support of time-varying timezone abbreviations  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Proposal for better support of time-varying timezone abbreviations
List pgsql-hackers
Tree view
On Tue, Oct 7, 2014 at 5:05 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

  typedef struct
  {
! char token[TOKMAXLEN + 1]; /* now always null-terminated */
  char type;
! int32 value;
  } datetkn;

Being entirely new to this code, "now" makes me think of the "current timestamp". I think this word can be removed to reduce ambiguity.


+ /* use strncmp so that we match truncated tokens */
   result = strncmp(key, position->token, TOKMAXLEN); 

In your proposal you wanted to remove "crufty code that deals with non-null-terminated token strings". Is this some of that crufty code? Can it be removed?


-- Chris

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Scaling shared buffer eviction
Next
From: Kevin Grittner
Date:
Subject: Re: bad estimation together with large work_mem generates terrible slow hash joins