Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][RM2136] Include "?" on all routes that are loaded - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: [pgAdmin4][RM2136] Include "?" on all routes that are loaded
Date
Msg-id CAM9w-_nqndUsK-FfFB3Kk2PRWES8cKH1Dmnvc_yHRiSO6_yp3Q@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][RM2136] Include "?" on all routes that are loaded  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Responses Re: [pgAdmin4][RM2136] Include "?" on all routes that are loaded
List pgadmin-hackers
Tree view
Hi Hackers,

Attached is the updated patch and includes changes suggested by Khushboo.


On Wed, Aug 1, 2018 at 12:22 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Aditya,

- Some of the svg files (connect.svg, disconnect.svg in Query Tool) are left.
The problem is with image files used in
 
css files with url param. I did not find any way in webpack  to add url params to internal ulr's used in css. Apart from that everything is covered.

- The variable name (INTERNAL_VERSION_PARAM) in the config can be renamed as APP_VERSION_PARAM
This is done.
 

- The value of the INTERNAL_VERSION_PARAM can be 'ver' or 'v' instead of 'intver'.
Value set 'ver' for now. We can always change it later and thats why made it configurable.

Except above the patch looks good to me.

Thanks,
Khushboo

On Thu, Jul 26, 2018 at 5:54 PM, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch for RM2136 which will add "?<ver_param>=<ver>" to all the static files requested and will help in cache busting on upgrading pgAdmin4.
<ver_param> name is configurable and is present in config.py-INTERNAL_VERSION_PARAM.
The value <ver> is taken as APP_VERSION_INT (which is updated with every release).
Setting INTERNAL_VERSION_PARAM value to blank or None will disable the version param add.
New parameter INTERNAL_VERSION_EXTN (tuple) is also added to specify the file extensions for which the version param to be added. I have added a few for now.
Test cases included.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"




--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: [pgAdmin4][Patch]: RM #3511 Passwords not stored for ssh tunnel connections
Next
From: Akshay Joshi
Date:
Subject: [pgAdmin4][Patch]: RM #3458 Error when using python 3.7 Changed inversion 3.7: Enable PEP 479 for all code by default: a StopIteration errorraised in a generator is transformed into a RuntimeError.