Home > mailing lists

Re: [Patch] - Improve schema field validation order - Mailing list pgadmin-hackers

From	Aditya Toshniwal
Subject	Re: [Patch] - Improve schema field validation order
Date	June 15, 2022 12:50:40
Msg-id	CAM9w-_n=Dy+fDs8gQWifxJOek5JMb4GXFDUy9Hzc5zei77DJqA@mail.gmail.com Whole thread Raw
In response to	[Patch] - Improve schema field validation order (Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>)
List	pgadmin-hackers

Hi Yogesh,

You have moved the validate call inside the loop, which will call the validate method once for all the fields.

So in a form for 50 fields if I type anything in a field then it will call the validate method 50 times.

I do not agree with this code change.

On Wed, Jun 15, 2022 at 2:43 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:

Hi,

Please find the attached patch which corrects validation flow of the parent & nested schema fields.

Thanks,
Yogesh Mahajan
EnterpriseDB

Thanks,

Aditya Toshniwal

pgAdmin Hacker | Software Architect | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

From: Yogesh Mahajan
Date: 15 June 2022, 12:12:46
Subject: [Patch] - Improve schema field validation order

From: Nikhil Mohite
Date: 20 June 2022, 10:42:45
Subject: Re: [pgAdmin][RM-6132]: [React] Port debugger to React