Home > mailing lists

Re: Regarding feature #3319 - Mailing list pgadmin-hackers

From	Aditya Toshniwal
Subject	Re: Regarding feature #3319
Date	August 20 10:44:04
Msg-id	CAM9w-_n-Uh=rvV6CTESUnoiiUaUa2vxao7SJBVrrv1E0uMWRpQ@mail.gmail.com Whole thread Raw
In response to	Re: Regarding feature #3319 (Anil Sahoo <anil.sahoo@enterprisedb.com>)
Responses	Re: Regarding feature #3319
List	pgadmin-hackers

Tree view

Hi Anil,

There can be multiple query tools open with large files. Not entirely sure if storing in SQLite DB is a good idea.

External databases won't come in the picture as 99.99% users will not use external DB for desktop app. We're only doing this for desktop app.

And also consider the case where a SQL file is opened with some unsaved changes.

On Tue, Aug 20, 2024 at 9:11 AM Anil Sahoo <anil.sahoo@enterprisedb.com> wrote:

Hi Aditya,

As we are already storing the query history in the pgAdmin 4's database file.
I am planning to store the information the same way. That can be an internal database file like SQLite or external database.

Let me know if you all have any suggestions on this.

Thanks
Anil
--

Anil Sahoo
Software Engineer
www.enterprisedb.com
Power to Postgres

On Mon, Aug 19, 2024 at 11:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Anil,

On Mon, Aug 12, 2024 at 3:02 PM Anil Sahoo <anil.sahoo@enterprisedb.com> wrote:
Hi,

Yes, We will store the details that are needed to re-establish the connection.

How/Where are you planning to store the information? Query text could be large.

Regards
Anil
--
Anil Sahoo
Software Engineer
www.enterprisedb.com
Power to Postgres

On Mon, Aug 12, 2024 at 2:08 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, 12 Aug 2024 at 06:50, Anil Sahoo <anil.sahoo@enterprisedb.com> wrote:
Hi Hackers,

This feature #3319, demands the Workspace and the Query tool panel to be saved before exiting the application and on restart it will show earlier opened panels.

We are already saving the Browser layout, Query tool layout and the Object explorer tree state but to save the contents of panels we will initially start with the Query tool. The below implementation will be done,
Store the query tool panels and the list of connections present in each query tool panel and the active connection
Store the query that is written in the editor
Store the contents of scratch pad
The main reason that this has never been worked on is that there is no way to restore the state of a connection to what it was and be sure we've got it right. How do you propose to handle that? I assume in a similar way to the warnings we give if a connection has to be re-established?

We will use debouncing to store the workspace data and all other data related to panels in the pgAdmin 4's configured database file. Through debouncing we will be able to call the API at certain intervals of user interaction, and it will update the stored data related to workspace and all other panels.

OK.

--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com

PGDay UK 2024, 11th September, London: https://2024.pgday.uk/

--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Architect | enterprisedb.com
"Don't Complain about Heat, Plant a TREE"