Re: [pgAdmin4][Patch] - RM 5481 update is truncating data for typecharacter with length - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: [pgAdmin4][Patch] - RM 5481 update is truncating data for typecharacter with length
Date
Msg-id CAM9w-_mqLhsaw1j+Zo4Pd2ZcD-y6NCnkZvn0vzoAA4xzAAmrRA@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch] - RM 5481 update is truncating data for typecharacter with length  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Hi Akshay,

The patch looks good to me. The test cases work fine. I've also tested with custom domain types and is working fine.

On Mon, May 25, 2020 at 3:45 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the data truncation issue when updating the data of the type character with length. To fix this issue I have created a ignore type cast list, where while inserting/updating we ignore the typecasting for the mentioned data type.

Added test cases for character and bit Data Type. 

Please review it. 

--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: [pgAdmin4][Patch] - RM 5481 update is truncating data for typecharacter with length
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed data truncation issue when updating the data of