Re: [pgAdmin][RM-7132]: Port Properties collection, Dashboard and SQL panel in React - Mailing list pgadmin-hackers
Hi Pradip,
I did some basic usage and review and found below issues:
1. The code fails if you refresh the page and go to properties, when no node is selected.
2. I found below UI issues on selecting a database node. Also, checkbox column is too wide.
3. Why is this in the node.js file. It should be in node_view.jsx.
+
+ ReactDOM.render(
+ <Theme>
+ <CollectionNodeView
+ node={node}
+ treeNodeInfo={treeNodeInfo}
+ item={item}
+ itemNodeData={d}
+ pgBrowser={pgBrowser}
+ ></CollectionNodeView>
+ </Theme>,
+ b.panels['properties'].panel.$container[0]
+ );
4. I have seen a lot of commented codes. Few samples:
+ // if (that.canHide) {
+ // pgBrowser.Events.off('pgadmin-browser:tree:selected', () => {
+
+ // removePanelView($container[0]);
+ // });
5. In WelcomeDashboard.jsx, the complete SVG code is put. Please move it to a file and import it.
6. Cleanup web/pgadmin/dashboard/static/js/dashboardDummy.js
7. Cleanup web/pgadmin/dashboard/static/js/dashboard_ponents.jsx
8. Rename Sql.jsx to SQL.jsx
9. The search is not working. It filters all.10. If there is huge data then it should show some spinner.
11. Delete buttons should be disabled if no object is selected.
12. Delete buttons and search box should be on the same line.
On Tue, Mar 15, 2022 at 4:01 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi AdityaCan you please review/test it?On Mon, Mar 14, 2022 at 7:17 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch for #7132 Port Properties collection, Dashboard and SQL panel in React.--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment
pgadmin-hackers by date: