[pgAdmin][RM4873] Change comment of a procedure with arguments - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject [pgAdmin][RM4873] Change comment of a procedure with arguments
Date
Msg-id CAM9w-_mDceEFJcs7FZiYhgNy1wfuHPYvRajH_Auj13BizoBwZg@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin][RM4873] Change comment of a procedure with arguments  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Hi Hackers,

Attached is a patch to fix following issues:
1) Change comment of procedure with arguments as a procedure can be overloaded. Note that on EPAS servers, procedure overloading works only for v11+ .
2) The save button of a procedure dialog is enabled without any change. Fixed.
3) Fixed formatting of the reverse engineered SQL.
4) On EPAS servers, parameters set were not displayed in the SQL generated. They are visible only if set to edbsql. Fixed.
5) Changing the volatility option of any existing procedure was not working. Fixed.
6) Changing the parallel option (EPAS v9.6+) was not working. Fixed.
7) Added RE-SQL test cases for procedures. Fixes #4620.

Please review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment

pgadmin-hackers by date:

Previous
From: Ganesh Jaybhay
Date:
Subject: [pgAdmin][4709] Invalid FTS configuration token dictionaries
Next
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Merged adjustanct 'if' statements when allowed.