Re: [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error
Date
Msg-id CAM9w-_kyf8reg8pw+qa=CaRKiU0i5Vfmyj34BSDSTXB6dP8w4w@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error  (Pradip Parkale <pradip.parkale@enterprisedb.com>)
Responses Re: [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error  (Pradip Parkale <pradip.parkale@enterprisedb.com>)
List pgadmin-hackers
Hi Pradip,

Just did a go through to your patch. 
The variable "data" which you've formed, will be computed for every row even though columns won't change. You should move it up and pass it to gen directly. This will save repeated computations.
Secondly, it should not be named as data. It can be like - numeric_cols or numeric_keys.

On Fri, Jun 11, 2021 at 7:17 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch for #6520.Added check to typecast the numeric data while downloading the data in CSV format.

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed issues related to About dialog:
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin][RM6231]- Add OS, Browser details in pgAdmin About us pop-up