Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure
Date
Msg-id CAM9w-_=ttwFCYe8wD4t9NK7vfdgJLu=4g13_GQZ0W71=jA2aDA@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Khushboo,

I suggest, 
1) Remove the commented code

+                # if 'mail' in entry:

+                #     user_email = entry['mail'].value

2) Change the below condition to check "is not None" instead which makes more sense.

+        if not self.bind_user or not self.bind_pass:


Other changes looks fine.

On Mon, Jul 6, 2020 at 11:29 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya,

Can you please review it.

On Mon, Jul 6, 2020 at 11:17 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch for the RM 5484 - Support LDAP based auth also when users do not have the same DN structure.

Currently, pgAdmin only supports LDAP authentication with the same DN structure. With this patch, the LDAP authentication will also support the different DN by setting the dedicated user for the LDAP connection in the config file.

Thanks,
Khushboo



--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed code smell 'Variable should not be shadowed'