Re: Add --system-identifier / -s option to pg_resetwal - Mailing list pgsql-hackers

From Nikolay Samokhvalov
Subject Re: Add --system-identifier / -s option to pg_resetwal
Date
Msg-id CAM527d-D+XyyQxy+pzyu_RhpP=Q_qz69d__Gzdbaynas-8Yeeg@mail.gmail.com
Whole thread Raw
In response to Re: Add --system-identifier / -s option to pg_resetwal  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: Add --system-identifier / -s option to pg_resetwal
Re: Add --system-identifier / -s option to pg_resetwal
List pgsql-hackers
Thank you, Peter and Michael, for the reviews

Attached is v2, simplified as suggested:
- Removed short option -s
- Removed interactive confirmation and --force
- Simplified tests leaving only essential ones

Additionally, there was an off-list review done by Andrey Borodin, so his comments also addressed:
- Simplified logic, getting rid of '-' check (negative numbers) -- decided to accept negative input values (they wrap to valid positive uint64)

Nik


Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pgsql: postgres_fdw: Inherit the local transaction's access/deferrable
Next
From: Sami Imseih
Date:
Subject: Re: Add log_autovacuum_{vacuum|analyze}_min_duration