Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: Fixes #1986 - Properly handle non-ascii characters while loading & saving file - Mailing list pgadmin-hackers

From Surinder Kumar
Subject Re: [pgAdmin4][Patch]: Fixes #1986 - Properly handle non-ascii characters while loading & saving file
Date
Msg-id CAM5-9D_vE2BdhkRxGH_M-KMnLhveUaUCFje0CrSs_XQ9AaEyBw@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch]: Fixes #1986 - Properly handle non-ascii characters while loading & saving file  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
Responses Re: Re: [pgAdmin4][Patch]: Fixes #1986 - Properly handle non-ascii characters while loading & saving file  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Please ignore above patch. because it breaks when we save a file with name containing ascii chars in py35
It is fixed. Please find attached patch and review.

On Thu, Nov 24, 2016 at 2:56 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi

Issue:
The content will not write to disk if it contains ascii characters.

Solution:
Encode/Decode the content before writing/reading the file.

By the way, the file/folder name should also encode/decode, a similar issue is already logged
#1940. I will work on it.

Please find attached path and review.


Thanks,
Surinder Kumar



Attachment

pgadmin-hackers by date:

Previous
From: Murtuza Zabuawala
Date:
Subject: PATCH: To fix issue in database node (pgAdmin4)
Next
From: Harshal Dhumal
Date:
Subject: Re: Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]