Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters - Mailing list pgadmin-hackers

From Surinder Kumar
Subject Re: [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters
Date
Msg-id CAM5-9D_mXq9y15EysJwCsk5wsTXtr+trcNv4upzMKTp3ruSrGw@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
List pgadmin-hackers
Tree view
This patch doesn't fix the issue in Procedure node. I will send updated patch.

On Mon, Sep 12, 2016 at 3:12 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi,

Please find attached patch with fix.
Changes:
1) Take a list of "function argument types", create a string separated by comma(removing trailing comma).
2) Function arguments in ALTER and GRANT not necessarily to have argument mode, name, they are optional. Only type is required.
Now GRANT statement is represented as

GRANT EXECUTE ON FUNCTION test_schema.test_func(integer, integer, integer) TO postgres as in pgadmin3.


Please review.

pgadmin-hackers by date:

Previous
From: Surinder Kumar
Date:
Subject: [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Prevent creation of packages and rules in catalogs. F