[pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes betweenexecutions of the same query in the query tool - Mailing list pgadmin-hackers

From Surinder Kumar
Subject [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes betweenexecutions of the same query in the query tool
Date
Msg-id CAM5-9D_AAy6vLL3kMDVKPhtpDe_bNFH0o+uc-4RajZFeypFe+g@mail.gmail.com
Whole thread Raw
In response to [pgadmin-hackers] [pgAdmin4][Patch][Feature #1971]: Remember column sizes betweenexecutions of the same query in the query tool  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
Responses Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remembercolumn sizes between executions of the same query in the query tool  (Shruti B Iyer <siyer@pivotal.io>)
List pgadmin-hackers
Staged changes are missed in previous patch, so please ignore.
Please find attached updated patch.

On Mon, Jun 5, 2017 at 4:29 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi

This patch contains two fixes:

1) In Query/tool or Edit grid, the width of table column header is fixed depending on the column type(int, boolean, char etc.) due to which the column name or type appears cut from right and doesn't looks good from user point of view. The main concern was to display as much as the content of column should be displayed.

Now the width of column is decided using the text length of column name or column type so that the column takes exact width it required and it don't appears cut.

2) Remember column size after re-running a query.

The approach is to extract table name from the query executed and use it to store its columns width.
Whenever the column(s) width of a table is adjusted, the corresponding values are updated into the object and used every time the same query is executed.

If a query is executed for e.g:

SELECT generate_series(1, 1000) as id, generate_series(1, 1000) as name, generate_series(1, 1000) as age

​it ​
displays 3 columns
​but don't have any table name. In that case,
 i use a hash generator function which returns unique hash for a query written in query editor and adjusted column(s) width are stored against that hash in object.

Is there any way to get temporary table name(avoiding unique hash) for such queries ?​

Also, Moved utilities functions into pgadmin/static/utils.js 

Please find attached patch and review.

Thanks,
Surinder Kumar

Attachment

pgadmin-hackers by date:

Previous
From: Surinder Kumar
Date:
Subject: Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience
Next
From: Dave Page
Date:
Subject: Re: [pgadmin-hackers] Style guide live website - looking for feedback