Postgres Pro
Downloads
Home   >   mailing lists

[pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only - Mailing list pgadmin-hackers

From Surinder Kumar
Subject [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only
Date
Msg-id CAM5-9D_+dUN79tJoK35Vq2oXLybeBwVFPFKHmF5NPKg6HR_c3Q@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Hi

While working on RM1391 I found another issue 'Backup is not working on windows".

The reason is that the process executor which uses subprocess Popen() to execute job fails when we pass close_fds=True and shell=False in windows.

Now we are settings close_fds=False and shell=True to fix it. These settings are specific to windows only.

Please review the attached patch.


Thanks,
Surinder Kumar
Attachment

pgadmin-hackers by date:

Previous
From: Murtuza Zabuawala
Date:
Subject: PATCH: To fix JSON array handling (pgAdmin4)
Next
From: Navnath Gadakh
Date:
Subject: Re: Regression errors - database node