Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text editpop up renders off page when the size of the grid exceeds the size of the window - Mailing list pgadmin-hackers

From Surinder Kumar
Subject Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text editpop up renders off page when the size of the grid exceeds the size of the window
Date
Msg-id CAM5-9D896-j25vv0RTj2EC0WJcuytCsPC1phmgwnpj4sv_mMQQ@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text editpop up renders off page when the size of the grid exceeds the size of the window  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text editpop up renders off page when the size of the grid exceeds the size of the window  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Hi

The current font-family applied to slick-grid is 'Verdana,Arial,sans-serif'.
I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif but the font size and spacing between text is reduced. so to match style I used "Verdana".

Also, as per my knowledge, the Helvetica font will work only for Operating Systems where this font actually exists in system, otherwise it will pick Arial font.

The right way to use 'Helvetica' is to download its 'ttf' and 'eot' files and use in CSS so that it appears same on all machines:
https://stackoverflow.com/questions/13013616/css-helvetica-neue-not-working

But it seems it is not available for free
https://www.myfonts.com/fonts/linotype/neue-helvetica/licensing.html

On Mon, Jun 12, 2017 at 6:16 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Can you update this so that the CSS all follows the standards in the
WIP styleguide please? I see that the current patch is using the wrong
font for example.

http://pgadmin4-styleguide.cfapps.io/

Thanks!

On Mon, Jun 12, 2017 at 11:57 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> Changes:
>
> 1) Calculate text editor position properly when the size of the grid exceeds
> the size of the window.
>
> 2) Assign NumberEditor to cell types('oid', 'xid', 'real').
>
> 3) Remove inline styles from rendered editors and move its styles to CSS
> file.
>
> Please find attached patch and review.
>
> Thanks
> Surinder
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: pgAdmin 4 Jenkins
Date:
Subject: [pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python35 #155
Next
From: Dave Page
Date:
Subject: Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in RoleMembership control