[pgAdmin4][Patch]: Fixes #1940 - Handle non-ascii characters in file/folder names - Mailing list pgadmin-hackers

From Surinder Kumar
Subject [pgAdmin4][Patch]: Fixes #1940 - Handle non-ascii characters in file/folder names
Date
Msg-id CAM5-9D-MbhJHNeJRpNRGwr-mxvSKrKMTwDu7p-A9Ju6NMOh6Yg@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin4][Patch]: Fixes #1940 - Handle non-ascii characters in file/folder names  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Hi

This patch handles encode/decode issues for files names when following operations are performed such as "create/rename/delete/download/upload" or browsing a file etc.

Changes in code:
1) Removed cleanstring() js function which converts ascii characters into its alphabetical characters.
We support ascii characters for file/folder name.
2) Read/Write file in bytes mode(rb/wb) as file need not be always text file.
3) The title of query tab is currently shown encoded, it should be decoded while displaying in tab title.

Please find attached patch and review.


Thanks,
Surinder Kumar
Attachment

pgadmin-hackers by date:

Previous
From: Harshal Dhumal
Date:
Subject: Re: Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]
Next
From: Neel Patel
Date:
Subject: [Patch]: RM#1979 - Editing Function Issues