Re: Free indexed_tlist memory explicitly within set_plan_refs() - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Free indexed_tlist memory explicitly within set_plan_refs()
Date
Msg-id CAM3SWZTgghD0HBgHAHBn7ekGh7oCZbEWw5UMy-C2A4tC3crjHg@mail.gmail.com
Whole thread Raw
In response to Re: Free indexed_tlist memory explicitly within set_plan_refs()  (Peter Geoghegan <pg@heroku.com>)
List pgsql-hackers
On Sat, May 30, 2015 at 3:12 PM, Peter Geoghegan <pg@heroku.com> wrote:
> Debugging this allowed me to come up with a significantly simplified
> approach. Attached is a new version of the original fix. Details are
> in commit message -- there is no actual need to have
> search_indexed_tlist_for_var() care about Vars being resjunk in a
> special way, which is a good thing.

It feels wrong to not have the additional, paranoid IsVar() check
within pull_var_targetlist_clause() check added in most recent
revision, even though it should not be necessary. Attached delta patch
adds this check.

I need to stop working on weekends...
--
Peter Geoghegan

Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Free indexed_tlist memory explicitly within set_plan_refs()
Next
From: David Steele
Date:
Subject: Re: [CORE] postpone next week's release