Re: WAL consistency check facility - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: WAL consistency check facility
Date
Msg-id CAM3SWZTbzU88Lit9Arhy=Ra2yp4w5aipuiQgFW-KbzEGYKZXbg@mail.gmail.com
Whole thread Raw
In response to Re: WAL consistency check facility  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: WAL consistency check facility  (Kuntal Ghosh <kuntalghosh.2007@gmail.com>)
List pgsql-hackers
On Sat, Aug 27, 2016 at 9:47 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> Right, I think there is no need to mask all the flags.  However apart
> from BTP_HAS_GARBAGE, it seems we should mask BTP_SPLIT_END as that is
> just used to save some processing for vaccum and won't be set after
> crash recovery or on standby after WAL replay.

Right you are -- while BTP_INCOMPLETE_SPLIT is set during recovery,
BTP_SPLIT_END is not. Still, most of the btpo_flags flags that are
masked in the patch shouldn't be.


-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: WAL consistency check facility
Next
From: Amit Kapila
Date:
Subject: Re: WIP: Covering + unique indexes.